Skip to content

Fixed inverse kinematics#214

Open
MarleneBusch wants to merge 75 commits into
mainfrom
features/combined_optimization
Open

Fixed inverse kinematics#214
MarleneBusch wants to merge 75 commits into
mainfrom
features/combined_optimization

Conversation

@MarleneBusch

@MarleneBusch MarleneBusch commented May 29, 2026

Copy link
Copy Markdown
Member

Description

The main feature of this PR is the fixed inverse kinematics.

  • add second kinematics reconstruction method
  • add train test dataset splits for the kinematics reconstructor and surface reconstructor
  • rename the motor position optimizer to aim point optimizer
  • for the kinematics and surface reconstruction pytests, i have removed test heliostat AA31 and instead added one more sample to test heliostat AA39, to keep the compute load similar but increase the information gain in the reconstruction with very few samples.

Fixes #205
Fixes #213 (there is now only one .pt file storing all tensors used in the pytests in a dict, this reduces 35 files into 1 file, it is slightly less userfriendly maybe, so if this change is not wanted I can revert it.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MarleneBusch MarleneBusch marked this pull request as ready for review June 1, 2026 09:35
@MarleneBusch MarleneBusch requested a review from mcw92 June 1, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine all data files in the tests dir Rename motor position optimization to aim point optimization

1 participant